Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review mixed use of Column Names and Property Names #102

Open
mattbrailsford opened this issue Nov 19, 2016 · 0 comments
Open

Review mixed use of Column Names and Property Names #102

mattbrailsford opened this issue Nov 19, 2016 · 0 comments

Comments

@mattbrailsford
Copy link
Collaborator

I'm not sure how big of a problem this is, it's just something that niggles me a bit that in various places we sometimes ask for column names, where as other, we ask for property names / keys. I think it might be nicer if we could use one and stick with it.

My inclination would be to use property names, as from those, we can work out column names, where as we can't easily go from column names to property names.

If we were to do this though, it would be a breaking change, so will likely have to wait till a major number increase, but thought I'd start the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants