Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we update the look and feel of the list view editor to the latest Umbraco List View prop editor styling #65

Open
TimGeyssens opened this issue Oct 26, 2016 · 8 comments

Comments

@TimGeyssens
Copy link
Owner

Since it was already based on that but on an older version...

@TimGeyssens
Copy link
Owner Author

So update to this styling
Image of Umbraco List View

@mattbrailsford
Copy link
Collaborator

Depends what versions of Umbraco we need to support. Personally I need to use it on a 7.3.3 install which was before this UI was used so we couldn't use their markup if we did. This is the problem with the back office UI changing so much :(

@mattbrailsford
Copy link
Collaborator

oops, didn't mean to close the issue :)

@TimGeyssens TimGeyssens added the UI label Oct 26, 2016
@TimGeyssens
Copy link
Owner Author

Ah yeah makes sense :) Not a priority works fine with the current layout

@TimGeyssens TimGeyssens added this to the 2.1 milestone Oct 27, 2016
@mattbrailsford
Copy link
Collaborator

In this commit eb559ee I've added Warrens umbraco version comparison util service https://gist.github.com/warrenbuckley/010aaf893551953732cc508c6b76d569 so that you can easily compare umbraco versions in angular. This could be the way we tackle the update, maintaining 2 views, one for pre 7.4 (where most of the new directives were added) and one for post 7.4.

@TimGeyssens
Copy link
Owner Author

Ok I see, thanks for adding! Still keeping this to 2.1 (the UI update) since I don't see that as necessary for v2

@mattbrailsford
Copy link
Collaborator

Agreed, just left as a note so we know how to go about it when it comes to it.

@TimGeyssens
Copy link
Owner Author

Perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants