Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

rename duration to align with ytdl-core #129

Open
TimeForANinja opened this issue Mar 10, 2022 · 0 comments
Open

rename duration to align with ytdl-core #129

TimeForANinja opened this issue Mar 10, 2022 · 0 comments

Comments

@TimeForANinja
Copy link
Owner

for ytdl it's named lengthSeconds
https://github.com/fent/node-ytdl-core/blob/master/typings/index.d.ts#L126
for ytsr it's named duration and durationSec https://github.com/TimeForANinja/node-ytpl/blob/master/typings/index.d.ts#L42-L43
so it would make sense to rename it to length and lengthSeconds

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant