Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt about resetting the root fontsize after a breakpoint #39

Open
ao2 opened this issue Jul 8, 2017 · 1 comment
Open

Doubt about resetting the root fontsize after a breakpoint #39

ao2 opened this issue Jul 8, 2017 · 1 comment
Labels

Comments

@ao2
Copy link

ao2 commented Jul 8, 2017

Hi,

I see that the media() mixin resets the root font size after applying the content to a breakpoint, and this is expected, however it always reset the value base on breakpoint 0: https://github.com/StudioThick/megatype/blob/master/megatype/_media.scss#L74

In case of nested media queries this could be incorrect.

Should the media mixin remember the last root fontsize and reset the value to that, instead of always reset based on breakpoint 0?

I have not experienced the problem myself, and I guess that nested media queries are not widely used, the doubt jut came by reading the code and I thought about asking about it.

Ciao,
Antonio

@ao2
Copy link
Author

ao2 commented Sep 18, 2017

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants