Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: interface crash and packet errors if there is no graphic tiles for "Floor" features #50

Open
EvgenijK opened this issue Oct 9, 2023 · 3 comments

Comments

@EvgenijK
Copy link
Contributor

EvgenijK commented Oct 9, 2023

Description

I encountered broken interface and client crashes when using graphic tiles.

After some blind investigation i found that problem did not occur if there is at least one "floor" in graphics.
Previously i had only monsters tiles in my graphics.

By "floor"s i mean this type of mapping:
F:1:/25

And "monsters" are:
R:229:/2

There were no problems when i tested on local server.

I tested on newest, fresh compiled versions of client and server.

My test tileset without floor tiles:
tomenet_gfx_example_without_floor.zip

In client

Received unknown packet type messages(from Net_packet()).
Interface is broken
Screenshot_20231009_235729

On server (own remote server)

RUPT messages (from Receive_unknownpacket())
Screenshot_20231009_235756

I couldn't found the bug in code, so created this issue.
Looks like i need @jezek help again ^^'

@jezek
Copy link
Contributor

jezek commented Oct 11, 2023

If it works on newest locally compiled and run server & client, than I would suggest to not bother, if the newest client gets some packet errors with live server. The live server doesn't have to be the latest version and there can be some development ongoing which currently breaks packets with newest client (try compile older client to see if packet error persist).

And from my previous experience it is nearly impossible (for me) to debug when an error happens only on live server and not on locally compiled & run server.

@CBlueGH CBlueGH closed this as completed Oct 21, 2023
@CBlueGH CBlueGH reopened this Oct 21, 2023
@CBlueGH
Copy link
Collaborator

CBlueGH commented Oct 21, 2023

Does this problem still persist with latest github code or is it fine?

@EvgenijK
Copy link
Contributor Author

Yes, this problem is not solved yet.
Don't have much time to investigate. may be others will check it, if we left issue opend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants