Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #65, Build failure when builddir contains spaces. #381

Closed
wants to merge 2 commits into from
Closed

Fixes #65, Build failure when builddir contains spaces. #381

wants to merge 2 commits into from

Conversation

Glavin001
Copy link

Fixes #65

@Glavin001
Update configure.js
6bfb29b 
Fixes nodejs#65. Build failure when builddir contains spaces.
Solution by @trentm.
See trentm@bbd979b
@Glavin001
Update configure.js
cb51279 
Minor typo fixes.
This was referenced Jan 6, 2014
Closed
Closed
@Glavin001
Copy link
Author

Looks like the solution @trentm suggested does not work. After trying to find out what the problem still was, I could not find a complete solution, and I do not know how inner workers of node-gyp and gyp. I was forced to rename my file path -- temporarily.
It is a small price to pay, but I doubt I will be using node-gyp in any projects if it requires manual changes on the user's end.

@Glavin001 Glavin001 closed this Jan 8, 2014
@Glavin001 Glavin001 mentioned this pull request Jan 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure when builddir contains spaces.
1 participant
@Glavin001