-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kerberos auth support #313
Comments
Here is how VS Code implemented it: https://github.com/microsoft/vscode/blob/9c2b9327e5cdce9583ef6cfe5072102b150cf7cb/src/vs/workbench/api/node/proxyResolver.ts#L151-L159 Without support for multi-step negotiate that resolves to NTLM, as they only do one step. And they also cache domains that requested Negotiate, so they don't have to hit them without credentials just to get 407 again. |
It looks like they use an extension and patches of this library though, we will need an additional callback to be able to asynchronously add such credentials, the current headers callback is sync, and also won't allow handling the 407 and auto-detecting to use such auth, or saving state about the request. |
Looks like they had to extend EDIT: Actually the callback should already be robust enough for multi-step, since you can probably store the |
Some networks use proxies with Kerberos (AKA Negotiate/SPNEGO/GSSAPI) based authentication, it would be nice if this package supported it, it can likely be implemented using https://www.npmjs.com/package/kerberos. (Note that Negotiate requires multiple round trips when it falls back to NTLM on Windows)
The text was updated successfully, but these errors were encountered: