Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0: Issue Undoing Split during Pause #181

Closed
Toufool opened this issue Oct 29, 2022 · 2 comments
Closed

2.0.0: Issue Undoing Split during Pause #181

Toufool opened this issue Oct 29, 2022 · 2 comments

Comments

@Toufool
Copy link
Owner

Toufool commented Oct 29, 2022

repro:
have two split images:
001_SplitImage_[100]
002_SplitImage

When a match occurs for 001_SplitImage_[100], it enters the pause state for 100 seconds. The next split is now 002_SplitImage.

During that 100 seconds, you should be able to click Undo Split in the "Pause" state and it will go back to 001_SplitImage_[100]. In 2.0.0, clicking Undo Split goes back to that image, but it does not appear.

Same behavior when using < button

2.0.0.mp4
1.6.1.mp4
@Avasam
Copy link
Collaborator

Avasam commented Nov 16, 2022

From Discord:
I believe this was intended. The reasoning: If you have to undo a split with an autosplitter, it's most likely because you hit a false positive. If undoing the split started comparing immediately again, it makes it impossible to go back by more than a single split (as it'll re-trigger immediately)
Edit: it was on purpose, see #68

https://cdn.discordapp.com/attachments/567370622263492623/1041861450077052928/undo_while_paused.mp4

If you prefer the behavior in 1.6.1, then I can make it an option ("Keep comparison paused when undoing split"). Since it's really just about whether or not this check is run

@Toufool
Copy link
Owner Author

Toufool commented Dec 23, 2022

@Avasam I'm super late on this sorry, but yea I think what you described makes sense. We can leave it how it is in 2.0 currently.

@Toufool Toufool closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants