Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Capture device: dropdown when Capture method: is not Video Capture Device #196

Closed
Toufool opened this issue Jan 21, 2023 · 2 comments
Labels
enhancement New feature or enhancement request

Comments

@Toufool
Copy link
Owner

Toufool commented Jan 21, 2023

Self explanatory. I think this will avoid confusion. When it's disabled, maybe we can set the text to something like "Select video capture device above" or something. Kind of like this

image

And then when Video Capture Device is selected, we can enable the dropdown to select the device.

@Avasam
Copy link
Collaborator

Avasam commented Jan 26, 2023

I generally agree with the request for a design change here. But there's one critical issue the current design works around:
If a video device would cause extra lag(1) or cause an unrecoverable error(2) and is the default(3) then the "Video Capture Device" option becomes unusable.


  1. Shouldn't be much of an issue with async device info. Was more of a problem during development. Could maybe cause the GV-USB2 to freeze?
  2. Unfortunately OBS' own integrated Virtual Cam is such a case that causes an uncatchable hard crash with OpenCV.
  3. I think it's better if there's a way for the user to select the capture device they wanna use before we try to use it.

We could unselect the capture device whenever a different capture method is selected. I doubt a regular user would often swap between them and need the capture device to be remembered. Then your request can be implemented as-is.

@Toufool
Copy link
Owner Author

Toufool commented Feb 20, 2023

Functionality for this looks good.

@Toufool Toufool closed this as completed Feb 20, 2023
@Avasam Avasam added enhancement New feature or enhancement request and removed 2.0.0 Request labels Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants