Add fresnel functions #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
agalbachicar
force-pushed
the
agalbachicar/#265_add_fresnel_functions
branch
from
97c35da
to
3cc7b5f
Compare
Signed-off-by: Agustin Alba Chicar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
===========================================
- Coverage 86.34% 68.95% -17.40%
===========================================
Files 232 344 +112
Lines 11450 17282 +5832
===========================================
+ Hits 9887 11916 +2029
- Misses 1563 5366 +3803
|
Signed-off-by: Agustin Alba Chicar <[email protected]>
agalbachicar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of maliput/maliput_malidrive#265
Summary
Adds support for Fresnel Cosine and Sine functions.
The implementation has been inspired in the CEPHES library and libOpendrive libraries respectively. Proper license attributions can be found in code.
Test it
Via unit tests.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.