Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Updates to Gemma #594

Closed
1 task done
cmathw opened this issue May 14, 2024 · 0 comments · Fixed by #596
Closed
1 task done

[Bug Report] Updates to Gemma #594

cmathw opened this issue May 14, 2024 · 0 comments · Fixed by #596

Comments

@cmathw
Copy link
Contributor

cmathw commented May 14, 2024

Since support for Gemma was merged March 14th, there have been a number of changes to the upstream HF model file such that we no longer have good agreement across logits and cache. A large chunk of these changes exist here but I think there are also more recent relevant changes in other commits. I will be opening a corresponding PR to address these issues tomorrow, in the meantime I would not trust Gemma outputs and activations.

Checklist

  • I have checked that there is no similar issue in the repo (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant