Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dict properties won't work with node v4.0 and v4.1 #34

Closed
misterdjules opened this issue Sep 19, 2015 · 3 comments
Closed

dict properties won't work with node v4.0 and v4.1 #34

misterdjules opened this issue Sep 19, 2015 · 3 comments
Labels

Comments

@misterdjules
Copy link
Contributor

https://codereview.chromium.org/1296743003/ landed in V8's master today and a PR to float it in node master and v4.x was sent today as well.

As a result, this metadata was not updated for node v4.0 and v4.1. Even if these releases are not considered LTS releases, I'm wondering if it's worth it to implement a workaround for this problem by hard-coding the type to int when V8's version is within the range of the versions used by node v4.0 and v4.1.

Hopefully nodejs/node#2959 will land soon and will be available in the next v4.x releases.

@misterdjules
Copy link
Contributor Author

nodejs/node#2959 which updates bit_field3's type and nodejs/node#2974 which adds ScopeInfo's constants to V8's post-mortem metadata have anded in nodejs/master, and are flagged to land in the next v4.x release.

So hopefully the post-mortem metadata for the next v4.x release of node will be more up to date.

@davepacheco
Copy link
Contributor

Is this resolved by #32/#33?

@misterdjules
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants