to grep or ggrep

[ghost]

the case of /usr/bin/grep not supporting -E is more and more frustrating, and seemingly the use of putting /opt/pkg/gnu/bin ahead of /opt/pkg/sbin:/opt/pkg/bin seems if not apalling but destined for failure.
here is another case:

richard@devzone:~/src/pkgsrc$ echo $PATH
/opt/pkg/sbin:/opt/pkg/bin:/opt/pkg/gcc47/bin:/usr/bin:/usr/sbin:/sbin
richard@devzone:~/src/pkgsrc$ pkg_update_summary ~/src/pkgsrc/packages/All/pkg_summary.txt ~/src/pkgsrc/packages/All
awk: syntax error near line 1
awk: bailing out near line 1
grep: illegal option -- E
Usage: grep [-c|-l|-q] -hbnsviw pattern file . . .
/opt/pkg/bin/pipestatus: line 96: [: -eq: unary operator expected
richard@devzone:~/src/pkgsrc$ which grep
/usr/bin/grep
richard@devzone:~/src/pkgsrc$ /opt/pkg/gnu/bin/grep  -E
Usage: /opt/pkg/gnu/bin/grep [OPTION]... MOTIF [FICHIER]...
Try '/opt/pkg/gnu/bin/grep --help' for more information.
richard@devzone:~/src/pkgsrc$ grep -E
grep: illegal option -- E
Usage: grep [-c|-l|-q] -hbnsviw pattern file . . .
richard@devzone:~/src/pkgsrc$ export PATH=/opt/pkg/gnu/bin:$PATH
richard@devzone:~/src/pkgsrc$ pkg_update_summary ~/src/pkgsrc/packages/All/pkg_summary.txt ~/src/pkgsrc/packages/All
richard@devzone:~/src/pkgsrc$ pkg_update_summary ~/src/pkgsrc/packages/All/pkg_summary.gz ~/src/pkgsrc/packages/All 'gzip -dc' 'gzip -c'
richard@devzone:~/src/pkgsrc$ cd packages/All/
richard@devzone:~/src/pkgsrc/packages/All$ ls pkg_summary.
pkg_summary.gz   pkg_summary.txt  
richard@devzone:~/src/pkgsrc/packages/All$ ls pkg_summary.txt 
pkg_summary.txt

Shouldn't either illumos update /usr/bin/grep to accept the gnu grep equivalents or somehow we need to use /opt/pkg/bin/ggrep, else find out how to ease the pain of using /opt/pkg/gnu/bin by default at the head of the PATH.

I doubt that is it possible to get pkgsrc to use egrep (or rather gegrep) instead of grep -E given the following extract:

richard@devzone:~/src/pkgsrc$ gegrep --help
Usage: gegrep [OPTION]... MOTIF [FICHIER]...
Cherche MOTIF dans chaque FICHIER ou à partir de l'entrée standard.
MOTIF est une expression régulière étendue
Exemple: gegrep -i 'hello world» menu.h main.c
...
Invocation as 'egrep' is deprecated; use 'grep -E' instead.
When FILE is -, read standard input.  With no FILE, read . if a command-line
-r is given, - otherwise.  If fewer than two FILEs are given, assume -h.
Exit status is 0 if any line is selected, 1 otherwise;
if any error occurs and -q is not given, the exit status is 2.

Rapporter toutes les anomalies à : [email protected]
Page web GNU Grep : <http://www.gnu.org/software/grep/>
Aide générale des logiciels GNU : <http://www.gnu.org/gethelp/>

Perhaps ggrep -E is the best pkgsrc oriented solution... Is there a way to replace grep by /opt/pkg/bin/ggrep in mk.conf? I tried setting the following, to no avail:

TOOLS_PLATFORM.grep?=           /opt/pkg/bin/ggrep

Observations, please?

[ghost]

In wip/pkg_summary_utils I found these cases using grep -E:

richard@devzone:~/src/pkgsrc/wip/pkg_summary-utils/work.devzone/pkg_summary-utils$ grep ' grep -.*E' *
pkg_update_src_summary:#xargs grep -lE "^[[:space:]]*${fields_re}[[:space:]]*[?!+]=" \
pkg_update_src_summary.in:#xargs grep -lE "^[[:space:]]*${fields_re}[[:space:]]*[?!+]=" \
richard@devzone:~/src/pkgsrc/wip/pkg_summary-utils/work.devzone/pkg_summary-utils$ grep ' grep -.*E' */*
tests/test_pkg_grep_summary.sh:    grep -E 'PKGNAME|---' |
tests/test_pkg_grep_summary.sh:    grep -E 'PKGNAME|PKGPATH|^$|MAINTAINER|COMMENT' |
tests/test_pkg_grep_summary.sh:    < src_summary.txt | grep -E '^(PKGNAME|PKGPATH|MAINTAINER)=|^$|^--' |
tests/test_pkg_micro_src_summary.sh:    grep -E 'Bad package| ----------' "$@"
tests/test_pkg_src_summary.sh:    grep -E 'Bad package| ----------' "$@"
tests/test_pkg_uniq_summary.sh:pkg_uniq_summary -n src_summary.txt | grep -E '^(PKGNAME=|PKGPATH=)|^$' |
tests/test_summary2multi_variants.sh:    grep -E 'Bad package| ----------' "$@"
tests/test.sh:    grep -E '^(PKGNAME|PKGPATH)=|^$|^-' "$@"

but the following output is interesting:

richard@devzone:~/src/pkgsrc/wip/pkg_summary-utils$ bmake show-tools
AWK=/opt/pkg/bin/nawk
BASENAME=/usr/bin/basename
CAT=/usr/bin/cat
CHGRP=/usr/bin/chgrp
CHMOD=/usr/bin/chmod
CHOWN=/usr/bin/chown
CMP=/bin/cmp
CP=/bin/cp
CUT=/usr/bin/cut
DATE=/usr/xpg4/bin/date
DIFF=/usr/bin/diff
DIRNAME=/usr/bin/dirname
ECHO=echo
EGREP=/usr/xpg4/bin/grep\ -E
SETENV=/usr/bin/env
EXPR=/usr/xpg4/bin/expr
FALSE=false
FILE_CMD=/usr/bin/file
FIND=/usr/bin/find
GREP=/opt/pkg/bin/ggrep
GZIP_CMD=/usr/bin/gzip\ -nf\ -9
HEAD=/usr/bin/head
HOSTNAME_CMD=/bin/hostname
ID=/usr/xpg4/bin/id
INSTALL=/opt/pkg/bin/install-sh
LN=/usr/bin/ln
LS=/usr/bin/ls
MKDIR=/usr/bin/mkdir\ -p
MV=/usr/bin/mv
PAX=/bin/pax
PRINTF=/bin/printf
PWD_CMD=/bin/pwd
RM=/usr/bin/rm
RMDIR=/usr/bin/rmdir
SED=/opt/pkg/bin/nbsed
SH=/usr/bin/bash
SORT=/usr/bin/sort
TAIL=/usr/xpg4/bin/tail
TEST=test
TOUCH=/usr/bin/touch
TR=/usr/xpg4/bin/tr
TRUE=true
WC=/usr/bin/wc
XARGS=/usr/bin/xargs

There is, then, GREP (changed as I indicated in mk.conf) and EGREP, which is by default /usr/xpg4/bin/grep -E

richard@devzone:~/src/pkgsrc/wip/pkg_summary-utils$ /usr/xpg4/bin/grep -E
Usage:  grep [-c|-l|-q] [-bhinsvwx] pattern_list [file ...]
        grep [-c|-l|-q] [-bhinsvwx] [-e pattern_list]... [-f pattern_file]... [file...]
        grep -E [-c|-l|-q] [-bhinsvx] pattern_list [file ...]
        grep -E [-c|-l|-q] [-bhinsvx] [-e pattern_list]... [-f pattern_file]... [file...]
        grep -F [-c|-l|-q] [-bhinsvx] pattern_list [file ...]
        grep -F [-c|-l|-q] [-bhinsvx] [-e pattern_list]... [-f pattern_file]... [file...]

bingo!
Furthermore, I notice that Garrett has proposed to replace /usr/bin/grep by /usr/xpg4/bin/grep
here (http://comments.gmane.org/gmane.os.illumos.devel/10147)

I vote YES, and in the meantime prepended /usr/xpg4/bin before /usr/bin in my PATH.

But back to pkg_summary-utils, shouldn't TOOLS_PLATFORM.grep replace grep with the indicated version?

[jperkin]

pkgsrc doesn't automatically replace all instances of e.g. 'grep' in third-party software with the correct version for each platform, you need to use e.g. the subst.mk framework to s/grep/${GREP}/ in the package. And yes, there is lots of broken software out there that needs to be patched :)