Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchman is broken (and old too) #423

Closed
jf opened this issue Oct 28, 2016 · 6 comments
Closed

watchman is broken (and old too) #423

jf opened this issue Oct 28, 2016 · 6 comments
Assignees

Comments

@jf
Copy link

jf commented Oct 28, 2016

Broken:

It seems like some patch is in order somewhere (I haven't found the appropriate place to patch yet, or else I'd submit a patch), but running watchman watch $SOMEDIR causes

$ watchman watch /tmp
1477691528: tid=2012794880 unable to talk to your watchman on /Users/pbulk/build/sysutils/watchman/work/.destdir/var/run/watchman/jf!

It appears that watchman is taking a cue from its build directory (and hence the /Users/pbulk/build/sysutils/watchman/work/.destdir prefix)

Old:

watchman is currently at 4.7.0 (see https://github.com/facebook/watchman/releases), vs 3.1 in pkgsrc.

@mamash mamash self-assigned this Oct 29, 2016
@mamash
Copy link

mamash commented Oct 29, 2016

Yep, that broke in 2015 with an ill-formed substitution on the part of pkgsrc. I'll fix that and update the package too.

@jf
Copy link
Author

jf commented Oct 29, 2016

Thanks, @mamash. I was painfully working my way through coming up with a working patch... but just realized that I could have simply gotten some clue from homebrew's own handling. If you're stuck, https://github.com/Homebrew/homebrew-core/blob/master/Formula/watchman.rb should come in handy (--prefix and --enable-statedir look great!)

@mamash
Copy link

mamash commented Oct 29, 2016

I fixed the 3.1 package in upstream pkgsrc trunk now.

I'll keep this pending for the update. Upstream has stopped maintaining SunOS support and diverted greatly from keeping things portable, so SunOS/SmartOS compatibility has been lost. I'll see if there's hope of reconciling the conflicts.

@jf
Copy link
Author

jf commented Oct 31, 2016

Thanks, @mamash. One question about SunOS/SmartOS: is the family officially supported? (I had the impression it was from http://pkgsrc.net/#platforms, and http://wiki.netbsd.org/pkgsrc/how_to_use_pkgsrc_on_solaris/#index3h1). If compatibility can't be fixed, what happens with regards to versioning? Will pkgsrc still use 3.1 in its tree... but Illumos et al use a separate tree with an older version?

@mamash
Copy link

mamash commented Oct 31, 2016

I only intend to give it a fair try to fix SunOS support. Otherwise I'll just update and SunOS week lose watchman until somebody cares enough to dedicate the effort needed.

pkgsrc platform support doesn't by far mean that all its packages will build and work on all supported platforms.

F.

    1. 2016 v 7:18, jf [email protected]:

Thanks, @mamash. One question about SunOS/SmartOS: is the family officially supported? (I had the impression it was from http://pkgsrc.net/#platforms, and http://wiki.netbsd.org/pkgsrc/how_to_use_pkgsrc_on_solaris/#index3h1). If compatibility can't be fixed, what happens with regards to versioning? Will pkgsrc still use 3.1 in its tree... but Illumos et al use a separate tree with an older version?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mamash
Copy link

mamash commented Nov 1, 2016

I made the update today, so 4.7.0 should hit the OS X packages in a few days.

There's just too much effort involved to make the code fully portable at this point:

facebook/watchman#322

@mamash mamash closed this as completed Nov 1, 2016
wiedi pushed a commit to wiedi/pkgsrc-legacy that referenced this issue Nov 17, 2016
version 1.11.1: 2016-06-14

    * new guesser infrastructure, support for emacs and vim modelines (TritonDataCenter#489)
    * javascript bugfix for nested objects with quoted keys (TritonDataCenter#496)
    * new theme: Gruvbox (thanks @jamietanna!)
    * praat: lots of improvements (thanks @jjatria)
    * fix for rougify error when highlighting from stdin (TritonDataCenter#493)
    * new lexer: kotlin (thanks @meleyal!)
    * new lexer: cfscript (thanks @mjclemente!)

version 1.11.0: 2016-06-06

    * groovy:
	o remove pathological regexes and add basic support for
	  triple-quoted strings (TritonDataCenter#485)
	o add the "trait" keyword and fix project url (thanks @glaforge! TritonDataCenter#378)
    * new lexer: coq (thanks @gmalecha! TritonDataCenter#389)
    * gemspec license now more accurate (thanks @connorshea! TritonDataCenter#484)
    * swift:
	o properly support nested comments (thanks @dblessing! TritonDataCenter#479)
	o support swift 2.2 features (thanks @radex TritonDataCenter#376 and @wokalski TritonDataCenter#442)
	o add indirect declaration (thanks @nRewik! TritonDataCenter#326)
    * new lexer: verilog (thanks @Razer6! TritonDataCenter#317)
    * new lexer: typescript (thanks @Seikho! TritonDataCenter#400)
    * new lexers: jinja and twig (thanks @robin850! TritonDataCenter#402)
    * new lexer: pascal (thanks @alexcu!)
    * css: support attribute selectors (thanks @skoji! TritonDataCenter#426)
    * new lexer: shell session (thanks @sio4! TritonDataCenter#481)
    * ruby: add support for <<~ heredocs (thanks @tinci! TritonDataCenter#362)
    * recognize comments at EOF in SQL, Apache, and CMake (thanks @julp! TritonDataCenter#360)
    * new lexer: phtml (thanks @Igloczek TritonDataCenter#366)
    * recognize comments at EOF in CoffeeScript (thanks @rdavila! TritonDataCenter#370)
    * c/c++:
	o support c11/c++11 features (thanks @Tosainu! TritonDataCenter#371)
	o Allow underscores in identifiers (thanks @coverify! TritonDataCenter#333)
    * rust: add more builtin types (thanks @RalfJung! TritonDataCenter#372)
    * ini: allow hyphen keys (thanks @KrzysiekJ! TritonDataCenter#380)
    * r: massively improve lexing quality (thanks @klmr! TritonDataCenter#383)
    * c#:
	o add missing keywords (thanks @BenVlodgi TritonDataCenter#384 and @SLaks TritonDataCenter#447)
    * diff: do not require newlines at the ends (thanks @AaronLasseigne! TritonDataCenter#387)
    * new lexer: ceylon (thanks @bjansen! TritonDataCenter#414)
    * new lexer: biml (thanks @japj! TritonDataCenter#415)
    * new lexer: TAP - the test anything protocol (thanks @mblayman! TritonDataCenter#409)
    * rougify bugfix: treat input as utf8 (thanks @japj! TritonDataCenter#417)
    * new lexer: jsonnet (thanks @davidzchen! TritonDataCenter#420)
    * clojure: associate *.cljc for cross-platform clojure (thanks @alesguzik! TritonDataCenter#423)
    * new lexer: D (thanks @nikibobi! TritonDataCenter#435)
    * new lexer: smarty (thanks @tringenbach! TritonDataCenter#427)
    * apache:
	o add directives for v2.4 (thanks @stanhu!)
	o various improvements (thanks @julp! TritonDataCenter#301)
	    - faster keyword lookups
	    - fix nil error on unknown directive (cf TritonDataCenter#246, TritonDataCenter#300)
	    - properly manage case-insensitive names (cf TritonDataCenter#246)
	    - properly handle windows CRLF
    * objective-c:
	o support literal dictionaries and block arguments (thanks @BenV!
	  TritonDataCenter#443 and TritonDataCenter#444)
	o Fix error tokens when defining interfaces (thanks @meleyal! TritonDataCenter#477)
    * new lexer: NASM (thanks @sraboy! TritonDataCenter#457)
    * new lexer: gradle (thanks @nerro! TritonDataCenter#468)
    * new lexer: API Blueprint (thanks @kylef! TritonDataCenter#261)
    * new lexer: ActionScript (thanks @honzabrecka! TritonDataCenter#241)
    * terminal256 formatter: stop confusing token names (thanks @julp! TritonDataCenter#367)
    * new lexer: julia (thanks @mpeteuil! TritonDataCenter#331)
    * new lexer: cmake (thanks @julp! TritonDataCenter#302)
    * new lexer: eiffel (thanks @Conaclos! TritonDataCenter#323)
    * new lexer: protobuf (thanks @fqqb! TritonDataCenter#327)
    * new lexer: fortran (thanks @CruzR! TritonDataCenter#328)
    * php: associate *.phpt files (thanks @Razer6!)
    * python: support raise from and yield from (thanks @mordervomubel! TritonDataCenter#324)
    * new VimL example (thanks @tpope! TritonDataCenter#315)
jperkin pushed a commit that referenced this issue Mar 4, 2017
Version 0.36
------------

Released on 2017-02-25.

New features:

* `#407 <https://github.com/Kozea/WeasyPrint/pull/407>`_:
  Handle ::first-letter.
* `#423 <https://github.com/Kozea/WeasyPrint/pull/423>`_:
  Warn user about broken cairo versions.

Bug fixes:

* `#411 <https://github.com/Kozea/WeasyPrint/pull/411>`_:
  Typos fixed in command-line help.


Version 0.35
------------

Released on 2017-02-25.

Bug fixes:

* `#410 <https://github.com/Kozea/WeasyPrint/pull/410>`_:
  Fix AssertionError in split_text_box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants