Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS curl should be built with http2 by default also #451

Closed
bahamat opened this issue Jan 15, 2017 · 4 comments
Closed

macOS curl should be built with http2 by default also #451

bahamat opened this issue Jan 15, 2017 · 4 comments
Assignees
@jperkin

Comments

@bahamat
Copy link
Member

bahamat commented Jan 15, 2017 •
edited
Loading

And if not too outrageous, please back port to 2016Q4 LTS.
@jperkin jperkin self-assigned this Jan 15, 2017
@jperkin
Copy link
Collaborator

jperkin commented Jan 15, 2017

This should have been done as part of SWSUP-567. If it didn't work properly let me know.

@jperkin jperkin closed this as completed Jan 15, 2017
@bahamat
Copy link
Member Author

bahamat commented Jan 16, 2017

Yep, you're right. I had tried it and got an error, but I tried it again just now and it worked. I must have accidentally used the platform curl.

Sorry for the noise, and thanks!

@bahamat
Copy link
Member Author

bahamat commented Jan 16, 2017

Found it...It's the macOS build that doesn't have it.

% uname -v
Darwin Kernel Version 16.3.0: Thu Nov 17 20:23:58 PST 2016; root:xnu-3789.31.2~1/RELEASE_X86_64
% pkg_info -e curl
curl-7.52.1
% /opt/pkg/bin/curl -i --http2 https://www.joyent.com/
curl: (1) Unsupported protocol

Whereas on SmartOS:

$ cat /etc/product
Name: Joyent Instance
Image: base-64-lts 16.4.0
Documentation: https://docs.joyent.com/images/smartos/base
$ pkg_info -e curl
curl-7.52.1
$ /opt/local/bin/curl -is --http2 https://www.joyent.com/ | head -2
HTTP/2 200 
date: Mon, 16 Jan 2017 05:41:36 GMT

@bahamat bahamat reopened this Jan 16, 2017
@bahamat bahamat changed the title curl should be built with http2 by default macOS curl should be built with http2 by default also Jan 16, 2017
jperkin referenced this issue in TritonDataCenter/pkgbuild Jan 17, 2017
Enable http2 option by default (joyent/pkgsrc#451).
8848093
@mamash
Copy link

mamash commented Feb 23, 2017

I see this was done last month, closing.

@mamash mamash closed this as completed Feb 23, 2017
jperkin pushed a commit that referenced this issue Mar 20, 2017
Update ruby-thor to 0.19.4.
c2628b0 
* pkgsrc change: add pkg_alternatives support.

0.19.4, release 2016-11-28

* Rename Thor::Base#thor_reserved_word? to #is_thor_reserved_word?

0.19.3, release 2016-11-27

* Output a warning instead of raising an exception when a default option value
  doesn't match its specified type

0.19.2, release 2016-11-26

* Fix bug with handling of colors passed to ask (and methods like yes? and no?
  which it underpins)
* Allow numeric arguments to be negative
* Ensure that default option values are of the specified type (e.g. you can't
  specify "foo" as the default for a numeric option), but make symbols and
  strings interchangeable
* Add Thor::Shell::Basic#indent method for intending output
* Fix remove_command for an inherited command (see #451)
* Allow hash arguments to only have each key provided once (see #455)
* Allow commands to disable class options, for instance for "help" commands
  (see #363)
* Do not generate a negative option (--no-no-foo) for already negative boolean
  options (--no-foo)
* Improve compatibility of Thor::CoreExt::HashWithIndifferentAccess with Ruby
  standard library Hash
* Allow specifying a custom binding for template evaluation (e.g. #key? and
  #fetch)
* Fix support for subcommand-specific "help"s
* Use a string buffer when handling ERB for Ruby 2.3 compatibility
* Update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jperkin jperkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jperkin @mamash @bahamat