gnupg21 needs patch to compile on macOS

[jooize]

GnuPG 2.1.16 requires the following patch to compile on macOS.

https://sourceforge.net/p/gpgosx/source/ci/release-1.7-for-gnupg-2.1.16/tree/patches/gnupg-2.1.16.patch

I got this error:

clang -I/opt/pkg/include -I/opt/pkg/include -I/opt/pkg/include -Wall -Wno-pointer-sign -Wpointer-arith  -pipe -DLDAP_DEPRECATED -I/opt/pkg/include  -lresolv -L/opt/pkg/lib -L/usr/lib -L/opt/pkg/lib -L/opt/pkg/lib -o gpgsplit gpgsplit.o ../common/libcommon.a -L/opt/pkg/lib -lgcrypt -Wl,-R/opt/pkg/lib -lgpg-error -Wl,-R/opt/pkg/lib -L/opt/pkg/lib -lgpg-error -lz -lbz2 -lintl /usr/lib/libiconv.dylib /usr/lib/libc.dylib -Wl,-framework -Wl,CoreFoundation  /usr/lib/libiconv.dylib
Undefined symbols for architecture x86_64:
  "_libintl_bind_textdomain_codeset", referenced from:
      _i18n_switchto_utf8 in libcommon.a(libcommon_a-i18n.o)
      _i18n_switchback in libcommon.a(libcommon_a-i18n.o)
  "_libintl_bindtextdomain", referenced from:
      _i18n_init in libcommon.a(libcommon_a-i18n.o)
      _i18n_localegettext in libcommon.a(libcommon_a-i18n.o)
  "_libintl_gettext", referenced from:
      _wrong_args in gpg_wks_client-gpg-wks-client.o
      _command_supported in gpg_wks_client-gpg-wks-client.o
      _command_send in gpg_wks_client-gpg-wks-client.o
      _connect_dirmngr in gpg_wks_client-call-dirmngr.o
      __init_common_subsystems in libcommon.a(libcommon_a-init.o)
      _disable_core_dumps in libcommon.a(libcommon_a-sysutils.o)
      _gnupg_rename_file in libcommon.a(libcommon_a-sysutils.o)
      ...
  "_libintl_setlocale", referenced from:
      _i18n_init in libcommon.a(libcommon_a-i18n.o)
      _i18n_localegettext in libcommon.a(libcommon_a-i18n.o)
      _send_pinentry_environment in libcommon.a(libcommon_a-asshelp.o)
  "_libintl_textdomain", referenced from:
      _i18n_init in libcommon.a(libcommon_a-i18n.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gnumake[2]: *** [gpg-wks-client] Error 1
gnumake[2]: *** Waiting for unfinished jobs....
mv -f .deps/make-dns-cert.Tpo .deps/make-dns-cert.Po
mv -f .deps/gpgtar-gpgtar-list.Tpo .deps/gpgtar-gpgtar-list.Po
mv -f .deps/gpgtar-gpgtar-create.Tpo .deps/gpgtar-gpgtar-create.Po
gnumake[1]: *** [all-recursive] Error 1
gnumake: *** [all] Error 2
*** Error code 2

Stop.
bmake[2]: stopped in /opt/pkg/src/security/gnupg21
*** Error code 1

Stop.
bmake[1]: stopped in /opt/pkg/src/security/gnupg21
*** Error code 1

Stop.
bmake: stopped in /opt/pkg/src/security/gnupg21

I ran bmake clean && bmake extract, applied the patch manually, and then bmake install.

[mamash]

Upstream fixed this in 2.1.17 in November, the joyent/osx/trunk branch currently has 2.1.18 that builds fine.