-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path
validation to signers & verifiers
#69
Comments
Perhaps |
That would be very nice, but the biggest win is just having any error saying "path" instead of just generating an invalid, or failing verify a, signature which indicates very little. So the simplest impl is just ensuring the path starts with |
Also related to the proposed reason deduction, but this issue is much easier to achieve https://truelayer.slack.com/archives/C01UYLYQ2HE/p1655124955742179 ^^ that would actually suggest the correct path in the signing case. I should move that proposal to an issue here... |
Since path should always start with
/
we can validate that this is the case and return a helpful error before an incorrect signature or incorrect verify usage ends in an opaque error.E.g. trying to use the whole url
.path("https://example.com/foo")
. We could produce something like an errorinvalid path "https://example.com/foo" must start with '/'
.We can use the full url scenario as a new test for signing & verifying in all langs.
Checklist:
The text was updated successfully, but these errors were encountered: