Permissions #296
Merged
Permissions #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#290 - change ownership of content and versions directory only - don’t add current user to ghost group
- change ownership of the content folder only - symlink casper to the current installation - remove casper update completely as it will always point to the relevant version
- now with 100% less linting errors
acburdine
reviewed
Jul 6, 2017
lib/commands/install.js
Outdated
| }, { | ||
| title: 'Summoning Casper', | ||
| task: this.casper | ||
| }], false, {concurrent: false}) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
- `concurrent: false` is default
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this pull request
Jul 6, 2017
no issue - with the permissions change in TryGhost#296, the ownership of the ghost directory was changed. Because of this we need to sudo remove the directory on uninstall
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this pull request
Jul 6, 2017
no issue - with the permissions change in TryGhost#296, the ownership of the ghost directory was changed. Because of this we need to sudo remove the directory on uninstall
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this pull request
Jul 6, 2017
no issue - with the permissions change in TryGhost#296, the ownership of the ghost directory was changed. Because of this we need to sudo remove the directory on uninstall
acburdine
added a commit
that referenced
this pull request
Jul 6, 2017
no issue - with the permissions change in #296, the ownership of the ghost directory was changed. Because of this we need to sudo remove the directory on uninstall
|
This still creates the same problem I had before, only for the /content/ directory, rather than the whole folder. The content dir still has drwxr-xr-x permissions, meaning my admin user cannot write to the files inside, and I therefore cannot import images or read the logs. The message also reads "changing permissions" still, I think it should be "changing ownership" because permissions are not being changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #290