feat(db): remove knex-migrator dep, use one installed with Ghost #505
Conversation
acburdine
force-pushed
the
remove-knex-migrator
branch
from
1f2df2a
to
7bd195f
Compare
|
That would be a great improvement 👍 As soon as we merge the v3 of knex-migrator into Ghost (see TryGhost/Ghost#9199), i am concerned that people will run into problems because of different versions in the CLI and in Ghost. Is this update something we could release asap? Do you need any help? |
|
Is there a concept of forcing people to update to the latest CLI version? I doubt. |
refs TryGhost#503 - use knex-migrator version installed with Ghost itself - remove global knex-migrator dependency - remove "same node version" check
acburdine
force-pushed
the
remove-knex-migrator
branch
from
7bd195f
to
c0b1dd7
Compare
|
@kirrg001 To the first question: yes - I can get this released today or tomorrow. The second question: no, there isn't a way currently to force people to upgrade to the latest Ghost-CLI version. However, I have an idea as to how to make that work, will create a PR for it asap. |
| @@ -37,16 +37,6 @@ const tasks = { | |||
| }); | |||
| }, | |||
| nodeVersion: function nodeVersion(ctx) { | |||
| const globalBin = execa.shellSync('npm bin -g', {preferLocal: false}).stdout; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| knexMigratorPromise = context.ui.sudo(`${knexMigratorPath} ${args.join(' ')}`, {sudoArgs: '-E -u ghost'}); | ||
| } else { | ||
| knexMigratorPromise = execa('knex-migrator-migrate', args, { | ||
| preferLocal: true, | ||
| localDir: __dirname | ||
| localDir: path.join(context.instance.dir, 'current') |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
refs #503