feat(system) add os and version to System class #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, is there a reason we're using our own commands and not something like https://www.npmjs.com/package/systeminformation ? imo using a library for it is probably a better approach here. |
aileen
changed the title
|
Thanks for the info. I will look into it, but with using If we decide to keep our own commands, I will source the fn out into a util, but still keep the command accessible from our System class. |
|
Sounds good to me to use our own commands - any refactoring can be done as part of addressing #540 |
aileen
changed the title
|
@acburdine This is ready for review! |
no issue - added a new getter to the System class, that returns the operating system as well as the version - works for linux, mac, and windows. Everything else falls back to the native `os.platform()` fn. - prints the os and the version in the debug information - added tests - updated issue template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
os.platform()fn.