-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(system) add os and version to System class #602
Conversation
Out of curiosity, is there a reason we're using our own commands and not something like https://www.npmjs.com/package/systeminformation ? imo using a library for it is probably a better approach here. |
Thanks for the info. I will look into it, but with using If we decide to keep our own commands, I will source the fn out into a util, but still keep the command accessible from our System class. |
Sounds good to me to use our own commands - any refactoring can be done as part of addressing #540 |
@acburdine This is ready for review! |
no issue - added a new getter to the System class, that returns the operating system as well as the version - works for linux, mac, and windows. Everything else falls back to the native `os.platform()` fn. - prints the os and the version in the debug information - added tests - updated issue template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
no issue
os.platform()
fn.