feat(command) prevent commands run as root user #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aileen
force-pushed
the
prevent-root-commands
branch
from
1348b14
to
1020206
Compare
refs TryGhost#47 - adds a `checkRootUser` fn to utils, which prevents any command to be run as `root` unless, it is set with the `allowRoot` property - adds test
aileen
force-pushed
the
prevent-root-commands
branch
from
1020206
to
fb9ac2a
Compare
kirrg001
pushed a commit
to kirrg001/Ghost-CLI
that referenced
this pull request
Feb 2, 2018
refs TryGhost#47 - adds a `checkRootUser` fn to utils, which prevents any command to be run as `root` unless, it is set with the `allowRoot` property - adds test
|
It would be great to have a switch that re-enable running as root. |
|
Running as root has never been supported - our docs have always made this clear, however we have run into numerous issues with this advice being ignored and subsequently causing support & maintenance overhead for the project, including the DO one-click installer incorrectly using root. Our goal is to keep Ghost-CLI maintainable for our small team (read more here). Therefore we are actively working to get users off of setups that cause support and maintenance overhead. I saw on slack that you're wanting to run using pm2 - this will be supported using extensions. We will not be adding a flag for running as root. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #47
checkRootUserfn to our base command class, which prevents any command to be run asroot