feat(doctor) show help message for install folder checks #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
reviewed
Feb 6, 2018
| @@ -10,8 +11,8 @@ const taskTitle = 'Checking current folder permissions'; | |||
| function installFolderPermissions(ctx) { | |||
| return fs.access(process.cwd(), constants.R_OK | constants.W_OK).catch(() => { | |||
| return Promise.reject(new errors.SystemError({ | |||
| message: `The current directory is not writable. | |||
| Please fix your directory permissions.`, | |||
| message: 'The current directory is not writable. Please fix permissions of your install directory.', | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
no issue - show clearer error message and help link to the docs, when install directory doesn't have the right permissions
aileen
force-pushed
the
improve-help-message
branch
from
1547ad0
to
09da7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue