-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(colors): Expose color-free logging option & add full support #653
Conversation
Of note: #680 should unblock this 😄 |
That's what I was thinking 😆 @kirrg001 should I leave TryGhost/Ignition#53 open for other usecases, or just not worry about it? |
@vikaspotluri123 I would close it. We can re-open it in case we want to add it 👍 |
@vikaspotluri123 mind rebasing this now that #680 is merged? |
36569eb
to
88c0266
Compare
lib/commands/log.js
Outdated
@@ -41,7 +41,7 @@ class LogCommand extends Command { | |||
} | |||
|
|||
const logFileName = path.join(instance.dir, 'content/logs', `${instance.config.get('url').replace(/[^\w]/gi, '_')}_${this.system.environment}${argv.error ? '.error' : ''}.log`); | |||
const prettyStream = new PrettyStream(); | |||
const prettyStream = new PrettyStream({color: argv.color}); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
88c0266
to
5320a77
Compare
5320a77
to
2804a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
refs + closes #457
depends on TryGhost/Ignition#53 (and assumes patch 19 will be released)