feat(colors): Expose color-free logging option & add full support #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of note: #680 should unblock this 😄 |
|
That's what I was thinking 😆 @kirrg001 should I leave TryGhost/Ignition#53 open for other usecases, or just not worry about it? |
|
@vikaspotluri123 I would close it. We can re-open it in case we want to add it 👍 |
|
@vikaspotluri123 mind rebasing this now that #680 is merged? |
vikaspotluri123
force-pushed
the
colorfree
branch
from
36569eb
to
88c0266
Compare
acburdine
reviewed
Mar 26, 2018
lib/commands/log.js
Outdated
| @@ -41,7 +41,7 @@ class LogCommand extends Command { | |||
| } | |||
|
|
|||
| const logFileName = path.join(instance.dir, 'content/logs', `${instance.config.get('url').replace(/[^\w]/gi, '_')}_${this.system.environment}${argv.error ? '.error' : ''}.log`); | |||
| const prettyStream = new PrettyStream(); | |||
| const prettyStream = new PrettyStream({color: argv.color}); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
vikaspotluri123
force-pushed
the
colorfree
branch
from
88c0266
to
5320a77
Compare
vikaspotluri123
force-pushed
the
colorfree
branch
from
5320a77
to
2804a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs + closes #457
depends on TryGhost/Ignition#53 (and assumes patch 19 will be released)