[Bug] Headings are being highlighted for certain keywords

[halfdan]

Reported in the forum: https://ghost.org/forum/bugs-suggestions/3261-greyed-out-heading/

Affected keywords are: signup, forgotten, reset

Since headings in the editor/preview are automatically annotated with an id they conflict with the CSS stylings of the signup form.

update by @ErisDS: notifications is another one, we need to make sure all IDs in sass are scoped or removed

[nicovalencia]

This actually seems to be an issue with Showdown, as it assigns sanitized header content to markup ids here. This is probably a bad idea in the first place, since having twin headers would invalidate the markup real quick.

I'll open an issue there to see if adding an id is even necessary. I'm not sure exactly what the purpose of including ids was to begin with.

Are you guys using/tracking the GitHub repo of Showdown or did you just pull the vendor-ed script off John Fraser's old site? I'll put in a PR to the Showdown repository for a fix, but if you guys have your own fork, we can just add it there (it doesn't look like the Showdown repo gets much activity).

[nicovalencia]

I've fixed the header id issues in Showdown, however the project hasn't been updated in over a year. We can manually pull my fork of Showdown into Ghost, or create a Ghost fork from that revision, however, the npm module also needs to be updated since Ghost is re-compiling the markdown server-side as well. This would require us to load a forked version of the module as well.

I yield strategy up to core, but let me know if you'd like me to do the module publishing or anything else to help. 😜

[ErisDS]

This issue has gone into a special 0.4.1 milestone for a maintenance release sometime within the next month. Master will continue to be work in progress for the active milestone 0.5. A special 0.4-maintenance branch has been created. The workflow for these fixes is that PRs for 0.4.1 should be made to that branch rather than master and then I will merge it back into master.

Unfortunately, it's not possible to change open PRs to go to a different branch, a brand new PR has to be created & the old one closed.There were already many PRs open for the 0.4.1 issues before the branch was created, and I am not asking or requiring anyone with an already open PR to master to do this - I am able to manually merge the changes into the right branch. However, I will appreciate anyone who has a few minutes to save me the job 👍

[ErisDS]

@nicovalencia apologies for missing your earlier comment. There should be no need to change showdown in order to resolve this issue, the offending IDs can either be changed to be classes, or be scoped to the right part of the DOM right within the CSS.

[ErisDS]

Updated to also include #notifications

[PaulAdamDavis]

Thanks, @ErisDS. I noticed #login also has the same issue. That's fixed locally. I'm going to look through all the Scss files and check for other issues like this.