Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Linking Data incorrectly generates author's Gravatar URL #4461

Closed
f3ndot opened this issue Nov 16, 2014 · 2 comments
Closed

JSON Linking Data incorrectly generates author's Gravatar URL #4461

f3ndot opened this issue Nov 16, 2014 · 2 comments

Comments

@f3ndot
Copy link

f3ndot commented Nov 16, 2014

version MSR1: 0.5.3

When creating a blog from scratch, using my gravatar email [email protected], the app incorrectly generates the following JSON Linking Data object for all posts:

    <script type="application/ld+json">
{
    "@context": "http://schema.org",
    "@type": "Article",
    <snipped>
    "author": {
        "@type": "Person",
        "name": "Justin Bull",
        "image": "http://blog.justinbull.ca//www.gravatar.com/avatar/d36bd9043f47f38990b0e5f622b314e2?d=404&s=250",
        "url": "http://blog.justinbull.ca/author/justin",
        "sameAs": "https://www.justinbull.ca"
    },
    <snipped>
}
    </script>

As you can see, because the Gravatar protocol was left out and the "same protocol as requested resource" shorthand // was used, whatever generates this link appended it to the blog url instead of replacing it.

FWIW I'm serving Ghost on its default port, localhost, with Apache listening on 443 proxying to it. The config.js defines the URL as http://blog.justinbull.ca because making it https causes an infinite loop.

@f3ndot f3ndot changed the title JSON Linking Data incorrectly generates Author's Gravatar URL JSON Linking Data incorrectly generates author's Gravatar URL Nov 16, 2014
@jaswilli
Copy link
Contributor

Hi @f3ndot ,

It looks like this was corrected in #4317 and will be included in the upcoming 0.5.4 release.

@f3ndot
Copy link
Author

f3ndot commented Nov 16, 2014

Ah thank you, my search terms were for "https" and "linking data" so I missed it.

For those who were wondering about that infinite redirect loop, I forgot to include RequestHeader set X-Forwarded-Proto "https" directive in my apache proxy config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants