Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings creation #736

Closed
ErisDS opened this issue Sep 14, 2013 · 4 comments
Closed

Settings creation #736

ErisDS opened this issue Sep 14, 2013 · 4 comments

Comments

@ErisDS
Copy link
Member

ErisDS commented Sep 14, 2013

From #567

When a specific setting is requested via GET, if it isn't found, we check to make sure it isn't specified in the default settings JSON, if it is, we return the default value and load that into the DB

When trying to create settings via PUT/POST, if a setting is not yet in the DB, we should again check if it is specified in the default settings JSON. If it is we should create it, but with the supplied value, if it isn't we probably should not create it for now.

We can add advanced permissions later for creating new settings? Although it really shouldn't be necessary as apps will have their own place to create settings.

@jgillich
Copy link
Contributor

Assign to me please. :)

Any news about advanced permissions, are they required? Or how is it done for the apps?

@ghost ghost assigned ricardobeat and sebgie Nov 26, 2013
@ErisDS
Copy link
Member Author

ErisDS commented Nov 26, 2013

Sorry @jgillich, @sebgie asked for this this one from me earlier, but I was on my way out the door and didn't get a chance to assign it.

@jgillich
Copy link
Contributor

No problem. This is probably related to #1547 so I'm looking forward to getting it fixed. :)

@ErisDS
Copy link
Member Author

ErisDS commented Jan 28, 2014

Closing this in favour of the more comprehensive: #2061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants