Skip to content
This repository has been archived by the owner on Jul 25, 2019. It is now read-only.

Google Sheets embeds are too small (integrations) #50

Open
kymellis opened this issue Dec 4, 2018 · 3 comments
Open

Google Sheets embeds are too small (integrations) #50

kymellis opened this issue Dec 4, 2018 · 3 comments
Assignees

Comments

@kymellis
Copy link
Contributor

kymellis commented Dec 4, 2018

I am working on the Integrations page for Google Sheets + Ghost, explaining how to embed a spreadsheet into a Ghost post. This is great for people who want to embed dynamic data or swipe files that their readers can export from their site.

When I published the page, the embed appears very small on the page:
google sheets embeds on docs

This is not a usable working example of this embed and should fit to the width of the content. Can we fix this?

The embed code used is:

<iframe src="https://docs.google.com/spreadsheets/d/e/2PACX-1vQKQwfka4cgU7mnS2uAiCMKs0wkmHJQdH5sc4mp231iVKjwueBVaX3Qy8no7gTihQXr6kwJ52TLyfLt/pubhtml?widget=true&amp;headers=false"></iframe>

Note: I've unpublished the Integrations page for now, but the content is in draft in Ghost Admin.

@kymellis kymellis changed the title Google Sheets embeds are too small Google Sheets embeds are too small (integrations) Dec 4, 2018
@aileen
Copy link
Member

aileen commented Dec 5, 2018

@kymellis The result looks the same to me with Casper (when I check the preview link), which doesn't make it right, but I think it's a general issue that we didn't tackle yet (and we should maybe think of opening the issue as well on Casper?)

I will assign this issue to @peterzimon as it's a design issue here.

@aileen aileen assigned peterzimon and unassigned aileen Dec 5, 2018
@kymellis
Copy link
Contributor Author

kymellis commented Dec 5, 2018

@AileenCGN @peterzimon OK sounds good. I already opened an issue on Casper here for the exact same problem.

I noticed that the same thing happens in Casper with some other embeds, too. But it's not always an issue because it depends on the content being embedded.

For example a Gist embed from GitHub on Casper looks like this:
screenshot 2018-12-05 at 17 40 11

This looks OK at a smaller size, but it would look better full-width.

This example already renders at the full-width on the live docs site: https://docs.ghost.org/integrations/github/

@kymellis
Copy link
Contributor Author

kymellis commented Jan 5, 2019

@peterzimon

I've now published the Backtracks integration using an OEmbed and it's not displaying quite right on the docs front-end. See here, the logo on the right is squished:

screenshot 2019-01-05 at 00 15 24

Should I create a new issue for this or is it OK in here?

@aileen aileen added the css label Jan 11, 2019
@JohnONolan JohnONolan removed the css label Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants