Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 13 (node-v79-linux-x64) #1246

Closed
thierry2015 opened this issue Nov 12, 2019 · 6 comments
Closed

Add support for Node 13 (node-v79-linux-x64) #1246

thierry2015 opened this issue Nov 12, 2019 · 6 comments

Comments

@thierry2015
Copy link

As a developer, I want to be able to support latest Node.js version (13.x) in order to use the latest engine features and to make sure all internal CLI users will be able to use my applications.

I work on internal business projects that are being used by developers, mostly through local CLI and distant Web interfaces. Some of them are on Node 12, some upgraded on 13 (we kept our servers on Node 12). Currently, the CI fails tests when on Node 13, not able to find the proper binding, which is supposed to be node-v79-linux-x64. However, the binding I get when on Bitbucket pipeline image node:latest is node-v72-linux-x64. All my CI tests are failing on the latest Node.js version because of this, but are successful on Node 12, on which binding resolves to node-v72-linux-x64. I use your package through knex.

Would it be something that you can fix in the next few weeks?

@kewde
Copy link
Collaborator

kewde commented Nov 14, 2019

#1247

@kewde
Copy link
Collaborator

kewde commented Nov 14, 2019

Please wait for #1248, we need to release a new version if you want to use prebuilt v13.
In the mean time, you can likely build this repository from source.

npm install sqlite3 --build-from-source

We will be providing compiled binaries for v13 in the next release.

@BackPacker777
Copy link

I'd like to +1 this!

@kewde
Copy link
Collaborator

kewde commented Dec 5, 2019

Please re-install sqlite3 to v4.1.1, they have been added, thanks.

@kewde kewde closed this as completed Dec 5, 2019
@thierry2015
Copy link
Author

Just tested it with bitbucket pipelines, it works as expected, thank you for the follow-up!

@BackPacker777
Copy link

Works for me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants