Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sqlite3 context aware for Electron 7+ compatibility #1274

Closed
MrMitch opened this issue Jan 25, 2020 · 8 comments
Closed

Make sqlite3 context aware for Electron 7+ compatibility #1274

MrMitch opened this issue Jan 25, 2020 · 8 comments

Comments

@MrMitch
Copy link

MrMitch commented Jan 25, 2020

We use sqlite3 in an Electron application and Electron is soon requiring Native Modules in the Renderer Process to be NAPI or Context Aware.

Is it possible to make sqlite3 Context Aware?
See electron/electron#18397 and an example https://github.com/atom/node-keytar/pull/182/files

Thanks

@kewde
Copy link
Collaborator

kewde commented Feb 8, 2020

We need to investigate #1007 again to make node-sqlite3 compatible with worker threads.
Then we can look at enabling support.

@ChrisHSandN
Copy link

There is also an open issue to add: N-API Support #830 which I guess would also solve this too - however that has been worked on for over 2 years now.

If Electron maintains their 12 week release schedule, version 11 (which will drop support for non converted modules) could be released around November 2020.

@bedwardly-down
Copy link

bedwardly-down commented Mar 3, 2020

With the shortage of contributors here, can I safely assume that Electron 8 will not be fully supported for a good while still? Or if there's a pretty good chance it will be coming pretty soon, could I get a rough time frame for that?

Speak of the holy devil. That timing couldn't have been crazier: #1294

I'm super excited for this

@kewde
Copy link
Collaborator

kewde commented Apr 28, 2020

#1304
Not yet released but will be available in 5.0.0

@kewde kewde closed this as completed Apr 28, 2020
@MrMitch
Copy link
Author

MrMitch commented Apr 28, 2020

@kewde thank you very much for your follow-up, much appreciated !

@aabuhijleh
Copy link

aabuhijleh commented May 7, 2020

Glad this change is made

@kewde, when do you think 5.0.0 will be published to npm?

@MrMitch
Copy link
Author

MrMitch commented Jul 1, 2020

@aabuhijleh v5 has been released (https://github.com/mapbox/node-sqlite3/releases/tag/v5.0.0) and is available on npm (https://www.npmjs.com/package/sqlite3)

@MrMitch
Copy link
Author

MrMitch commented Jul 1, 2020

thank you @kewde ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants