Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when load app in head tag #68

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Fix crash when load app in head tag #68

merged 3 commits into from
Jun 11, 2021

Conversation

trananhmanh89
Copy link
Contributor

Environment Info

  • Naive UI version: (eg. 2.11.0)
  • Browser Info: ( Chome 91)
  • System Info: (Windows 10 21H1)

Steps to reproduce

  • Create a static html site
  • Build a naive app with a nbutton
  • Include app js to head of html file
  • App crash, nothing show

Solution:

  • because app js was included to head, so document.body is null. Use document.createElement('div') instead.

@vercel
Copy link

vercel bot commented Jun 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/Dzy6zPSFfYiQYCxERATEW9u2D927
✅ Preview: https://naive-ui-git-fork-trananhmanh89-patch-1-tusimple.vercel.app

@vercel vercel bot temporarily deployed to Preview June 10, 2021 17:08 Inactive
@07akioni
Copy link
Collaborator

Please add changelog to the PR.

@trananhmanh89
Copy link
Contributor Author

Please add changelog to the PR.

Please tell me how. I don't know.

@07akioni
Copy link
Collaborator

07akioni commented Jun 10, 2021

Please add changelog to the PR.

Please tell me how. I don't know.

/CHANGELOG.en-US.md <-- add changelog
/CHANGELOG.zh-CN.md <-- add a changelog placeholder, I'll fill it

@trananhmanh89
Copy link
Contributor Author

Please add changelog to the PR.

Please tell me how. I don't know.

/CHANGELOG.en-US.md <-- add changelog
/CHANGELOG.zh-CN.md <-- add a changelog placeholder, I'll fill it

Hi,
A silly question. How can i add more commits to this PR? Or i have to create new PR for changelog?

@07akioni
Copy link
Collaborator

Please add changelog to the PR.

Please tell me how. I don't know.

/CHANGELOG.en-US.md <-- add changelog

/CHANGELOG.zh-CN.md <-- add a changelog placeholder, I'll fill it

Hi,

A silly question. How can i add more commits to this PR? Or i have to create new PR for changelog?

just change files and commit to your branch

@vercel vercel bot temporarily deployed to Preview June 11, 2021 01:19 Inactive
@trananhmanh89
Copy link
Contributor Author

just change files and commit to your branch

Done.

CHANGELOG.en-US.md Outdated Show resolved Hide resolved
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview June 11, 2021 02:32 Inactive
@07akioni 07akioni merged commit d4dba86 into tusen-ai:main Jun 11, 2021
@trananhmanh89 trananhmanh89 deleted the patch-1 branch June 17, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants