Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings generated when installing with npm #49

Open
bengrunfeld opened this issue Feb 8, 2019 · 1 comment
Open

Warnings generated when installing with npm #49

bengrunfeld opened this issue Feb 8, 2019 · 1 comment

Comments

@bengrunfeld
Copy link

Node version: v10.0.0
NPM version: 6.7.0

tradey $ npm install --save tulind

> [email protected] install /Users/ben/Desktop/Work/code/tradey/node_modules/tulind
> node-pre-gyp install --fallback-to-build

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(404): https://tulipnode.s3.amazonaws.com/tulind/v0.8.14/Release/tulind-v0.8.14-node-v64-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for [email protected] and [email protected] (node-v64 ABI, unknown) (falling back to source compile with node-gyp)
  CXX(target) Release/obj.target/tulind/tulind.o
../tulind.cpp:72:22: warning: comparison of integers of different signs:
      'const int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
    if (ind->options != options->Length()) {
        ~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
../tulind.cpp:236:10: warning: 'MakeCallback' is deprecated
      [-Wdeprecated-declarations]
    Nan::MakeCallback(Nan::GetCurrentContext()->Global(), callbackHandle...
         ^
../../nan/nan.h:929:3: note: 'MakeCallback' has been explicitly marked
      deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(
  ^
../../nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../tulind.cpp:127:21: warning: comparison of integers of different signs:
      'const int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
    if (ind->inputs != inputs->Length()) {
        ~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~
../tulind.cpp:134:22: warning: comparison of integers of different signs:
      'const int' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare]
    if (ind->options != options->Length()) {
        ~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
4 warnings generated.
  CC(target) Release/obj.target/tulind/external/tiamalgamation.o
  SOLINK_MODULE(target) /Users/ben/Desktop/Work/code/tradey/node_modules/tulind/lib/binding/Release/node-v64-darwin-x64/tulind.node
  COPY Release/tulind.node
+ [email protected]
added 31 packages from 17 contributors and audited 33401 packages in 16.34s
found 0 vulnerabilities
@codeplea
Copy link
Member

codeplea commented Feb 8, 2019

These warnings shouldn't affect performance.

If anyone wants to address them, I would appreciate the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants