Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-Real values in UntypedVarInfo #107

Closed
mohamed82008 opened this issue May 5, 2020 · 4 comments
Closed

Allow non-Real values in UntypedVarInfo #107

mohamed82008 opened this issue May 5, 2020 · 4 comments

Comments

@mohamed82008
Copy link
Member

mohamed82008 commented May 5, 2020

It would be nice to allow arbitrary types in UntypedVarInfo instead of just Reals. This should allow Turing to be used with distributions that sample letters, words, trees, images, etc. without having to represent them as an array of reals. The conversion to TypedVarInfo should work fine whatever type is in UntypedVarInfo so this may be as simple as changing Real to Any in a bunch of places.

@cpfiffer
Copy link
Member

cpfiffer commented May 5, 2020

I would like to see this a lot too -- I could imagine cases where someone had a distribution across bigrams or something and just wanted to work with the actual draws from that distribution.

It seems to me the hangup here is not really so much in DynamicPPL but in MCMCChains and various other spots in the Turing-verse.

@devmotion
Copy link
Member

Yep, it would be nice if we wouldn't make any assumptions about the support of the distributions we work with since we just need to be able to sample and evaluate the log pdf.

@trappmartin
Copy link
Member

Super exciting. I'm all in for this.

@yebai
Copy link
Member

yebai commented Nov 2, 2022

We probably don't need this anymore due to the planned transition to SimpleVarInfo.

@yebai yebai closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants