-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different transformed and untransformed variable lengths #241
Comments
I thought there was an issue about this in Bijectors, for inputs and outputs of different size but also more generally for inputs and outputs of different types, but I can't find it. So maybe it was only discussed in some PR. |
That's true but there is also a DPPL issue mostly in the VarInfo where linearized values in the transformed and untransformed domains are assumed to have the same length. |
A temporary solution is to resize when calling |
Or to not transform in-place (this was also discussed at some point) and/or to use a different non-linearized structure (IIRC there are some discussions that were moved to AbstractPPL). |
As a temporary workaround you can just fill the transformed values with 0s (or some other value) but I guess that's maybe what you want to avoid here. |
Closed in favour of #461 |
It would be nice to relax the assumption that transformed and untransformed variables must have the same linearized lengths. We can introduce a new function
variable_length
which takes a distribution argument and atransformed
kwarg. This function can then be defined for common distributions.The text was updated successfully, but these errors were encountered: