Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug statements etc #526

Closed
willtebbutt opened this issue Sep 13, 2018 · 2 comments · Fixed by #1499
Closed

Debug statements etc #526

willtebbutt opened this issue Sep 13, 2018 · 2 comments · Fixed by #1499
Assignees

Comments

@willtebbutt
Copy link
Member

We have quite a lot of @debug statements floating around the code base, and I wonder how much additional value a lot of them provide. Debug messages like @debug "run model..." in a function called runmodel really don't provide any additional information over and above what a stack trace already provides, while cluttering the code.

I would be keen to understand whether

  1. anyone feels that these debug messages provide value over and above what we get for free from stack traces and
  2. there would be any objections to removing a lot of the debug messages.
@willtebbutt willtebbutt changed the title Debug messages etc Debug statements etc Sep 13, 2018
@yebai
Copy link
Member

yebai commented Sep 13, 2018

@willtebbutt That's a good point - many of these codes are written when Julia's debugging environment is less mature. Indeed, some @debug messages are a bit redundant and can be safely removed.

@willtebbutt
Copy link
Member Author

Great. I'll do this once #513 is merged.

@willtebbutt willtebbutt self-assigned this Sep 13, 2018
@yebai yebai added this to the 0.5 milestone Sep 20, 2018
@yebai yebai mentioned this issue Jul 4, 2019
56 tasks
@yebai yebai modified the milestones: 0.7, 0.8 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants