Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Turing to 0.26, (keep existing compat) #92

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Turing package from 0.20, 0.21, 0.22, 0.23, 0.24, 0.25 to 0.20, 0.21, 0.22, 0.23, 0.24, 0.25, 0.26.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@storopoli storopoli force-pushed the compathelper/new_version/2023-06-16-00-10-14-363-00436373695 branch from a5758db to 910eff9 Compare June 16, 2023 00:10
@storopoli
Copy link
Member

@torfjelde of @devmotion, are there any changes in how logpdf is exported in Turing.jl 0.26?
I went to the changelog for Turing and DynamicPPL new versions but I could not find anything. I don't know why the tests are failing.

@yebai
Copy link
Member

yebai commented Aug 4, 2023

This should be fixed by TuringLang/DistributionsAD.jl#256

@storopoli
Copy link
Member

Now we need a new release on TuringLang/DistributionsAD.jl and a new release on TuringLang/Turing.jl

@yebai
Copy link
Member

yebai commented Aug 4, 2023

We only need a new DistributionsAD release, which is done. I triggered a re-run of CI; this PR should be ready for merging once CI passes.

@storopoli storopoli enabled auto-merge (squash) August 5, 2023 18:14
@storopoli storopoli disabled auto-merge August 5, 2023 18:14
@storopoli storopoli merged commit e82253e into main Aug 5, 2023
5 checks passed
@storopoli storopoli deleted the compathelper/new_version/2023-06-16-00-10-14-363-00436373695 branch August 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants