Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

C# ValidateTwilioRequestAttribute check flipped? #842

Open
c17r opened this issue Oct 2, 2020 · 0 comments
Open

C# ValidateTwilioRequestAttribute check flipped? #842

c17r opened this issue Oct 2, 2020 · 0 comments

Comments

@c17r
Copy link

c17r commented Oct 2, 2020

Perhaps I'm misunderstanding, but this line:

if (!IsValidRequest(context.Request) || !IsTestEnvironment)

Shouldn't that be if (!IsValidRequest(context.Request) && !IsTestEnvironment)? If the request is not valid and we're not in the test environment, then give the 403.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@c17r and others