Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ts-loader from 0.8.2 to 0.9.* breaks webpack hot module replacement #321

Closed
d0pare opened this issue Oct 17, 2016 · 10 comments
Closed

Comments

@d0pare
Copy link

d0pare commented Oct 17, 2016

I am using this angular2 template
When I updated ts-loader to 0.9.* it broke hot module replacement. Now all modules are rebuilding on every change.

With 0.8.2:

[HMR] connected
client.js:128 [HMR] bundle rebuilding
client.js:132 [HMR] bundle rebuilt in 224ms
process-update.js:27 [HMR] Checking for updates on the server...
process-update.js:100 [HMR] Updated modules:
process-update.js:102 [HMR]  - ./ClientApp/app/components/counter/counter.component.html
process-update.js:102 [HMR]  - ./ClientApp/app/components/counter/counter.component.ts
process-update.js:102 [HMR]  - ./ClientApp/app/app.module.ts
process-update.js:102 [HMR]  - ./ClientApp/boot-client.ts
process-update.js:107 [HMR] App is up to date.

With 0.9.3:

[HMR] connected
client.js:128 [HMR] bundle rebuilding
client.js:132 [HMR] bundle rebuilt in 5264ms
process-update.js:27 [HMR] Checking for updates on the server...
process-update.js:100[HMR] Updated modules:
process-update.js:102[HMR]  - ./ClientApp/boot-client.ts
process-update.js:102[HMR]  - ./ClientApp/app/app.module.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/app/app.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/navmenu/navmenu.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/home/home.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/fetchdata/fetchdata.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/counter/counter.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/counter/counter.component.html
process-update.js:107[HMR] App is up to date.
@d0pare d0pare changed the title Updating ts-loader to 0.9.* breaks webpack hot module replacement Updating ts-loader from 0.8.2 to 0.9.* breaks webpack hot module replacement Oct 17, 2016
@johnnyreilly
Copy link
Member

Are you able to confirm with what version of 0.9 this broke? 0.9.0 / 0.9.1 / 0.9.2 / 0.9.3 ?

@d0pare
Copy link
Author

d0pare commented Oct 17, 2016

I have checked boundary versions 0.9.0 and 0.9.3

@johnnyreilly
Copy link
Member

johnnyreilly commented Oct 17, 2016

Hmmm. I wonder if it's this:

ae824b2

Do you fancy forking, reverting that change, and reattempting?

Or perhaps this:

0b11576

@d0pare
Copy link
Author

d0pare commented Oct 17, 2016

I reverted the change and it worked.

So ae824b2 change is the issue.

@johnnyreilly
Copy link
Member

which one?

@d0pare
Copy link
Author

d0pare commented Oct 17, 2016

ae824b2

@johnnyreilly
Copy link
Member

Cool - that was just an optimisation a community member supplied. I'll plan to back it out in the next release. (or make it opt - in only... not decided). It would be good to have a test that covered this....

@johnnyreilly
Copy link
Member

Feel free to submit a PR BTW - will likely be doing a release later this week

@johnnyreilly
Copy link
Member

Released 0.9.4

@d0pare
Copy link
Author

d0pare commented Oct 17, 2016

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants