Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for node runMain bug #1846

Open
cspotcode opened this issue Jul 22, 2022 · 0 comments
Open

Tracking issue for node runMain bug #1846

cspotcode opened this issue Jul 22, 2022 · 0 comments

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Jul 22, 2022

Node shipped a Module.runMain bug in 18.6.0 introduced by loader chaining. They've subsequently implemented a fix: nodejs/node#43763

ts-node shipped a workaround that version-detects 18.6.0. The workaround doesn't preserve require.main and it's a hack I want to remove once the next node v18 is released.

Loader chaining and this fix are being backported to node v16. So v16 should never exhibit this behavior, but good to keep an eye on it.

This issue can be closed once we're able to remove the workaround hack for v18 and we've confirmed that node 16 ships loader chaining without the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant