This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Add Post/RelatedUrls #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the phpcs bug with PHPDoc type hints
stickler-ci
reviewed
Apr 24, 2017
src/Post/RelatedUrls.php
Outdated
| return 0; | ||
| } | ||
|
|
||
| return url_to_postid($url); |
There was a problem hiding this comment.
url_to_postid() is prohibited, please use wpcom_vip_url_to_postid() instead.
stickler-ci
reviewed
Apr 24, 2017
src/Post/RelatedUrls.php
Outdated
|
|
||
| $related = []; | ||
| foreach ($terms as $term) { | ||
| $link = get_term_link($term, $taxonomy); |
There was a problem hiding this comment.
get_term_link() is prohibited, please use wpcom_vip_get_term_link() instead.
stickler-ci
reviewed
Apr 24, 2017
src/Post/Finder.php
Outdated
| return null; | ||
| } | ||
|
|
||
| $postId = url_to_postid($cleanUrl); |
There was a problem hiding this comment.
url_to_postid() is prohibited, please use wpcom_vip_url_to_postid() instead.
tangrufus
force-pushed
the
related-urls
branch
2 times, most recently
from
eaae14f
to
79a591c
Compare
stickler-ci
reviewed
Apr 24, 2017
src/Post/Finder.php
Outdated
| return; | ||
| } | ||
|
|
||
| $postId = url_to_postid($cleanUrl); |
There was a problem hiding this comment.
url_to_postid() is prohibited, please use wpcom_vip_url_to_postid() instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.