Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize and commit to API #28

Open
Tyriar opened this issue Apr 5, 2017 · 3 comments
Open

Finalize and commit to API #28

Tyriar opened this issue Apr 5, 2017 · 3 comments
Assignees

Comments

@Tyriar
Copy link
Owner

Tyriar commented Apr 5, 2017

Some open questions:

  • Should color1, color2, etc. be named accent1, accent2 or something more specific?
  • How do we mitigate heaps of language specific syntax color types such as markdownQuote, cssTag, etc.
@Tyriar Tyriar self-assigned this Apr 5, 2017
@wavebeem
Copy link

First of all, very cool project.

I think this is just something where you need to take a different approach to coloring things. Don't think of "variables are red" think of "variables are secondary accent color, keywords are primary accent color, comments are the muted color".

In my "Uno Due Tre" color scheme I generate all the syntax colors from just 3 hue values.

image

This may be more limited than what you want, but I find it's actually worked out quite well for me.

@Tyriar
Copy link
Owner Author

Tyriar commented Jun 16, 2017

@wavebeem I like it, it's a pretty big change though.

I had an idea to have "generator templates" which would create themes using different source colors and maybe have different features, such as having same background color for most things vs more contrast across the workbench, or a palette of a different size.

@wavebeem
Copy link

I could totally see two extra keys:

  • uiStyle: "light" | "dark" | high-contrast"
  • codeStyle: "2-tone" | "3-tone" | "many-colors"

So you could specify a few strategies for the UI theme vs the code theme. uiStyle could read from the background/foreground keys, and codeStyle could maybe read from an array of colors, which are sorted in order of importance or something? Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants