Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New workflow for image build #530

Closed
trevorcampbell opened this issue Sep 13, 2023 · 0 comments · Fixed by #531
Closed

New workflow for image build #530

trevorcampbell opened this issue Sep 13, 2023 · 0 comments · Fixed by #531
Labels
enhancement New feature or request low priority nice but not important or mandatory

Comments

@trevorcampbell
Copy link
Contributor

trevorcampbell commented Sep 13, 2023

We are likely going to merge UBC-DSCI/introduction-to-datascience-python#241 in the python version, which will build docker images on PRs to Dockerfile (also need to add main branch protection to avoid accidentally circumventing the workflow) instead of on commits to Dockerfile. That way we can easily review PRs with a stable image without needing to modify images interactively (and have a new image built when the PR merges, which might differ from the test environment)

If that works well there, we should eventually port it over to here too.

@trevorcampbell trevorcampbell added enhancement New feature or request low priority nice but not important or mandatory labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority nice but not important or mandatory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant