Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Request - FTVA Header Primary, Header Sticky, SiteBrand #570

Open
tinuola opened this issue Jul 26, 2024 · 1 comment
Open

Component Request - FTVA Header Primary, Header Sticky, SiteBrand #570

tinuola opened this issue Jul 26, 2024 · 1 comment
Assignees
Labels
feature feature

Comments

@tinuola
Copy link
Contributor

tinuola commented Jul 26, 2024

Component Description

This component request is for FTVA variants (usetheme: ftva) to be created for existing components; the variants will be assembled to build the FTVA Header section.

Existing components to be updated:

  • SiteBrand: the FTVA version will include a Donate button
  • NavPrimary: the FTVA version will include the recently created NavSearch component
  • HeaderSticky: the FTVA version only includes NavPrimary

Design

Default display:

ftva-header-primary

Search component display:

ftva-header-search-display

On hover and expanded:

ftva-header-hover-expanded

Responsiveness

Pending feedback and Updated preview(s) from UX:

https://www.figma.com/design/EKazRIMP4B15bD16UDbOwR/UCLA-Library-Design-System?m=auto&node-id=14773-5400&t=0J9aDhKfi3VDDFdf-1

  • Default NavPrimary component behavior on mobile: hamburger menu and overlay
  • Preferably, menu bar retains stickiness on mobile
  • Donate button should be at the bottom of the menu list
  • Search icon should be at the top, with the hamburger icon
    • The search field and the menu items display are coupled (in the overlay)
    • However, when the search icon is pressed, only the search field should be displayed; but when the hamburger is pressed the entire overlay (search and menu items) should be displayed
ftva-nav-mobile-collapsed

ftva-nav-mobile-pressed

ftva-nav-mobile-expanded

Slots

No slots

Props

No new props?

Developer Tips

List any developer tips here

  1. See annotations for specs
  2. pinia state name sTop which can be used to enable the header sticky in the default layout, when the user scrolls past brand bar which is approximately 40px: { "has-scrolled-past-brand": useStore.state.sTop >= 40 },
  3. Logic needed on mobile view to render search field alone when the search icon is pressed, and to render both search field and menu items when the hamburger is pressed

Events

  1. Header items on click reveal the expanded menu
  2. Search icon on click reveals the search component
  3. On mobile, the search icon reveals the search field; the hamburger icon reveals the search field and the menu items in the overlay

Child components

  • NavPrimary
  • HeaderSticky
  • SiteBrand
  • ButtonLink

Screenshots

ftva-header-desktop

ftva-header-mobile

@tinuola tinuola self-assigned this Jul 26, 2024
@tinuola tinuola added the feature feature label Aug 6, 2024
@tinuola tinuola changed the title WIP: FTVA Header Primary, Header Sticky, SiteBrand FTVA Header Primary, Header Sticky, SiteBrand Aug 6, 2024
@tinuola tinuola changed the title FTVA Header Primary, Header Sticky, SiteBrand Component Request - FTVA Header Primary, Header Sticky, SiteBrand Aug 6, 2024
@farosFreed
Copy link
Contributor

Approved, looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
None yet
Development

No branches or pull requests

2 participants