Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interested in (optional, default to off) support for using system-version of dependencies? #8

Open
traversaro opened this issue Sep 20, 2023 · 4 comments

Comments

@traversaro
Copy link
Contributor

Hello @triter3 , first of all thanks a lot for working on this library.

I am interested in adding a package for this library in conda-forge (a community maintained distribution of software and libraries for Windows/macOS/Linux), mainly as it is a dependency of https://github.com/google-deepmind/mujoco . For doing so, I need to do develop the following modification:

  • Add optional support for getting dependencies that are already available in the system (optional in the sense that the default way of getting dependencies will remain the existing one)
  • Add support for installing the library in the system

I can easily do the modification on my own and maintain them as patches, but I wanted to understand if you are interested in accepting this change in the repo. If yes, I can submit them as PRs. If you are not interested in this changes, no problem, I can maintain them as local patches.

Thanks a lot in advance!

@triter3
Copy link
Member

triter3 commented Sep 20, 2023

Hi @traversaro, thanks to you for using the library. I'm interested in integrating the modifications you are proposing. It will be an excellent feature to have.

@traversaro
Copy link
Contributor Author

Hi @traversaro, thanks to you for using the library. I'm interested in integrating the modifications you are proposing. It will be an excellent feature to have.

Hello @triter3, a first batch of modifications are proposed in #9 .

@keszegrobert
Copy link

Are there any changes on the way or can I open my own issue for the other changes?
install.patch

@traversaro
Copy link
Contributor Author

I did not prepared any further information PR, feel free to suggest it yourself, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants