Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

real/double mixing in SIGN calls #6

Open
Huite opened this issue Jul 22, 2024 · 0 comments
Open

real/double mixing in SIGN calls #6

Huite opened this issue Jul 22, 2024 · 0 comments

Comments

@Huite
Copy link
Collaborator

Huite commented Jul 22, 2024

Gfortran is unhappy about:

RSIGN=SIGN(1.0,RBRANCH)

Since 1.0 is a float, and in this case RBRANCH is a double.

Easy fix is to e.g. specify a constant like D_ONE as double:

REAL(8) D_ONE
D_ONE = 1.0


RSIGN=SIGN(D_ONE,RBRANCH)

I think converting every real to a double would be fine at this point too.
Memory usage definitely isn't a problem anymore, but roundoff definitely is. I don't think it'll affect runtimes much either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant