Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project configuration fails without nugetSources section in build.gradle #66

Closed
mmduyzend opened this issue Jun 20, 2018 · 4 comments
Closed

Comments

@mmduyzend
Copy link

Currently (version 2.16), without a nugetSources section defined in build.gradle, project configuration fails with "Operation not specified for NuGetSources task."

Projects that do not require a functional nugetSources task should not need to define this section for project configuration to succeed: Any error due to a missing or malformed nugetSources section should only occur on an attempt to invoke the nugetSources task, not during project configuration.

@citizenmatt
Copy link
Contributor

I'd be happy to send a PR for this. Not sure what the correct fix is though - simply move the validation checks from project.afterEvaluate to exec?

@gluck
Copy link
Contributor

gluck commented Sep 26, 2018

That or remove default nugetSources task creation from NuGetPlugin ?
Not sure it makes sense to have this task by default, sounds a bit of a special use case.

@gluck
Copy link
Contributor

gluck commented Sep 26, 2018

@darsen WDYT ?

@darsen
Copy link
Contributor

darsen commented Sep 27, 2018

I'd go with @citizenmatt proposal, moving validation to exec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants