Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative Extrusion is ignored when importing G-Code #19514

Open
EmJay276 opened this issue Aug 9, 2024 · 5 comments · May be fixed by #19515
Open

Relative Extrusion is ignored when importing G-Code #19514

EmJay276 opened this issue Aug 9, 2024 · 5 comments · May be fixed by #19515
Labels
Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior.

Comments

@EmJay276
Copy link

EmJay276 commented Aug 9, 2024

Cura Version

5.7.1

Operating System

Windows 10

Printer

All

Reproduction steps

  • Slice any model with relative extrusion setting
  • Import the G-Code

Actual results

grafik

Expected results

grafik

Add your .zip and screenshots here ⬇️

gcode.zip
@EmJay276 EmJay276 added Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior. labels Aug 9, 2024
@smartavionics
Copy link
Contributor

A quick look at the Cura 4 code shows that it only recognises relative extrusion (due to M83 in gcode) when the gcode flavour is RepRap.

@GregValiant
Copy link
Collaborator

I see the same thing (looking in FlavorParser.py) and the behavior does appear to go back to at least 4.13.1.
Arc Welder's G2 and G3 lines continue to be unsupported as well.

@EmJay276
Copy link
Author

EmJay276 commented Aug 9, 2024

Should adding these lines to the "general" FlavorParser.py not just fix it?

Cura/plugins/GCodeReader/RepRapFlavorParser.py

Lines 14 to 20 in e3287a1

def processMCode(self, M, line, position, path):
if M == 82:
# Set absolute extrusion mode
self._is_absolute_extrusion = True
elif M == 83:
# Set relative extrusion mode
self._is_absolute_extrusion = False

@EmJay276
Copy link
Author

EmJay276 commented Aug 9, 2024

I just tested it in my local installation, and yes, it does fix it.
I will create a PR.

@EmJay276 EmJay276 linked a pull request Aug 9, 2024 that will close this issue
Open
6 tasks
@EmJay276
Copy link
Author

EmJay276 commented Aug 9, 2024

You can test it in #19515 if you want 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PlugIn GCodeReader - Process M82 and M83 command for Marlin flavoured GCode EmJay276/Cura
3 participants
@smartavionics @EmJay276 @GregValiant