-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP Address/Hostname of Octoprint instance should be shown #465
Comments
Hmm, the problem I have with this is, that the value then would not match up with the actual config value, which could lead to a lot of confusion. From my point of view the config should reflect the actual config used by OctoDash ... Is there another reason for this, except that users might try to get the OctoPrint URL from the settings? |
In docker, you can ping hosts with their container name, since that's how the routing works. If I execute |
Users who have no idea about any of this in the makerspace, perhaps even first timers to 3d printing in general should be able to see the external address that octoprint is accessible at in case they want to access it, that's all I'm suggesting. Currently I use the config.printer.name to display the printer hostname |
I totally get your point that users should know the public address. Changing the url field to display something different than what is actually being used currently is no option for me since then, if someone wants to change the actual ip or hostname he/she would need to edit the config.json file. Is there maybe an option for you to put something beside the printer that tells the users the IP. This could also be something for the help screen, but I would like to display the actual config values in the config menu. I'm thinking of a private/public mode here, which would show the settings for private and a help icon with markdown for public mode ... |
Yeah there's no real way to automatically get this, as in my circumstance the device would be running in container and would think its IP address is 172.xx.xx.xx and hostname of |
Then there is also no easy way for OctoDash to get the correct IP of OctoPrint ... |
Misclicked on my phone, didn't mean to close the issue. |
I decided against showing another IP in the settings. There already is some confusion around this, so showing something different than is actually being used could create even more. |
This will eliminate confusion when people want to access the web interface locally here at the makerspace. The value in my case would be 10.0.50.1 for the IP and matt-octoprint.local for the hostname of the octoprint instance. The problem is, these values do not match up with the values inside the config, so this has to be user programmable for vanity, as the address used in the config is literally
octoprint
since all of my configuration is making use of docker containers on the one device.The text was updated successfully, but these errors were encountered: