Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder value validations #28

Open
Und3rf10w opened this issue Jun 10, 2018 · 0 comments
Open

Add builder value validations #28

Und3rf10w opened this issue Jun 10, 2018 · 0 comments
Labels
base logic Issues that affect how the base logic of the project builder Issues related to the builder functionality enhancement Issues related to a proposed enchancement to the project feature request help wanted

Comments

@Und3rf10w
Copy link
Owner

Need to add logic to validate builder values. For the most part, this just means making sure that the type of the value of a variable passed to the builder matches the one expected.

Currently, any builder value looks for the following token ```[var:::identifier_for_the_marker]``` and expects the user to perform validation on their own.

If we put the data type we expect in the var field, then it would be very easy to validate against it.

For example, for the C2_BLOCK_TIME, the current marker is ```[var:::c2_block_time]```. Since this type(C2_BLOCK_TIME) should always return <type 'int'>, it would be fairly simple to instead have the marker be ```[int:::c2_block_time]``` and refuse to compile if the provided value does not match the expected data type.

This would be something nice to have, and be a fairly low level of effort; but isn't necessarily critical. It COULD be done for the beta release, but as of right now, will not be assigned as a blocker for release.

@Und3rf10w Und3rf10w added enhancement Issues related to a proposed enchancement to the project help wanted feature request builder Issues related to the builder functionality base logic Issues that affect how the base logic of the project labels Jun 10, 2018
@Und3rf10w Und3rf10w mentioned this issue Jun 10, 2018
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base logic Issues that affect how the base logic of the project builder Issues related to the builder functionality enhancement Issues related to a proposed enchancement to the project feature request help wanted
Projects
None yet
Development

No branches or pull requests

1 participant