Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frameit-mmt: Verbalization of scroll-description has problems with recursion #564

Open
SESch93 opened this issue Jul 8, 2021 · 0 comments
Assignees
Labels

Comments

@SESch93
Copy link
Collaborator

SESch93 commented Jul 8, 2021

Initial situation: Added 3 PointFacts P, Q and R via the /fact/add endpoint of the frameit-server

Afterwards, a request to the /scroll/dynamic endpoint of the frameit-server, where we map A |-> P, B -> Q, C |-> R, will lead to a wrong description of the rendered-scroll.

  • actual description:

    Given a triangle △PQR right-angled at ⊾R, the opposide side has length CA = tan(∠ABC) ⋅ QR.

  • expected description:

    Given a triangle △PQR right-angled at ⊾R, the opposide side has length CA = tan(∠PQR) ⋅ QR.

The culprit is probably the recursive call to verbalize ${lverb angleB} that prints ∠ABC(the default verbalization) without accounting for the assignmentsA |-> P, B |-> Q, C |-> R`.

(edit: @ComFreek extended this bug report with more info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants