Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with current netcdf-cxx4 #184

Closed
WardF opened this issue Jan 4, 2016 · 2 comments
Closed

Fix compatibility with current netcdf-cxx4 #184

WardF opened this issue Jan 4, 2016 · 2 comments
Assignees
@WardF
Labels
arch/any area/general platform/any status/fix required type/enhancement
Milestone
4.4.0

Comments

@WardF
Copy link
Member

WardF commented Jan 4, 2016

The pull request which fixed several ARM-related issues (#159) may have been a little broad; it has broken compatibility with the current version of netcdf-cxx4. I'm going to walk some of the pull request back, using #ifdef where necessary, so that the API changes don't break anything for other projects right out of the box.
@WardF WardF self-assigned this Jan 4, 2016
@WardF WardF added this to the 4.4.0 milestone Jan 4, 2016
@WardF
Copy link
Member Author

WardF commented Jan 4, 2016

Working on branch gh159-walkback. It appears that the changes made to the API may have been unnecessary (as expected). Running tests now to confirm.

@WardF
Copy link
Member Author

WardF commented Jan 5, 2016

Issue resolved; I rolled back the API changes. These changes developed during the course of debugging the issue but were ultimately unnecessary. This also resolves the netcdf-cxx4 compatibility issue introduced by the fix.

@WardF WardF closed this as completed Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardF WardF

Labels
arch/any area/general platform/any status/fix required type/enhancement
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
1 participant
@WardF